Integrated: 8311162: Simplify and modernize equals and hashCode for java.net
Pavel Rappo
prappo at openjdk.org
Fri Jun 30 15:21:06 UTC 2023
On Fri, 30 Jun 2023 09:17:42 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
> Please review this PR to use modern APIs and language features to simplify `equals` and `hashCode` for the java.net package.
>
> Note, in NetworkInterface we could do even more and change this:
>
> for (InetAddress thisAddr : this.addrs) {
> boolean found = false;
> for (InetAddress thatAddr : that.addrs) {
> if (thisAddr.equals(thatAddr)) {
> found = true;
> break;
> }
> }
> if (!found) {
> return false;
> }
> }
> return true;
>
> to this:
>
> return Set.of(that.addrs).containsAll(Set.of(this.addrs));
>
> But arguably, the first option is already better enough than what was there before.
This pull request has now been integrated.
Changeset: e3a7e020
Author: Pavel Rappo <prappo at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/e3a7e020d2d92e4eafe79b3ecebf31ec058bc48f
Stats: 41 lines in 3 files changed: 10 ins; 18 del; 13 mod
8311162: Simplify and modernize equals and hashCode for java.net
Reviewed-by: dfuchs, michaelm, msheppar
-------------
PR: https://git.openjdk.org/jdk/pull/14726
More information about the net-dev
mailing list