RFR: 8303457: Introduce convenience test library APIs for creating test servers for tests in test/jdk/java/net/httpclient

[Daniel Fuchs]

On Wed, 1 Mar 2023 15:08:26 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review for this test-only change which addresses https://bugs.openjdk.org/browse/JDK-8303457?
> 
> Tests that reside in `test/jdk/java/net/httpclient/` create and use test servers for executing various HttpClient tests against those test servers. As noted in the JBS issue, the code in most of these tests is repeated for the test server creation. All these tests use the test library at `test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/`. 
> 
> The changes in this PR include a set of new APIs in `test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java` to help reduce the boilerplate. The rest of the changes across the existing tests is to use these new APIs. No functional changes to the tests has been done.
> 
> Locally the tests in `test/jdk/java/net/httpclient/` continue to pass with these changes. tier testing is in progress to verify no unforeseen regressions are introduced.

Thanks Jaikiran, that looks very good. Approving on the condition that all modified tests still pass.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12808