Integrated: 8303457: Introduce convenience test library APIs for creating test servers for tests in test/jdk/java/net/httpclient

Jaikiran Pai jpai at openjdk.org
Thu Mar 2 11:27:22 UTC 2023


On Wed, 1 Mar 2023 15:08:26 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review for this test-only change which addresses https://bugs.openjdk.org/browse/JDK-8303457?
> 
> Tests that reside in `test/jdk/java/net/httpclient/` create and use test servers for executing various HttpClient tests against those test servers. As noted in the JBS issue, the code in most of these tests is repeated for the test server creation. All these tests use the test library at `test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/`. 
> 
> The changes in this PR include a set of new APIs in `test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java` to help reduce the boilerplate. The rest of the changes across the existing tests is to use these new APIs. No functional changes to the tests has been done.
> 
> Locally the tests in `test/jdk/java/net/httpclient/` continue to pass with these changes. tier testing is in progress to verify no unforeseen regressions are introduced.

This pull request has now been integrated.

Changeset: 72de24e5
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/72de24e59a80a38ea4ea6a8a3f966f555987ac86
Stats:     548 lines in 47 files changed: 176 ins; 161 del; 211 mod

8303457: Introduce convenience test library APIs for creating test servers for tests in test/jdk/java/net/httpclient

Reviewed-by: dfuchs

-------------

PR: https://git.openjdk.org/jdk/pull/12808


More information about the net-dev mailing list