RFR: 8293786: HttpClient will not send more than 64 kb of data from the 2nd request in http2 [v2]

[Conor Cleary]

On Tue, 7 Mar 2023 09:28:01 GMT, Conor Cleary <ccleary at openjdk.org> wrote:

>> Conor Cleary has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - 8293786: Server-side reset implemented, updated comments on incoming_reset
>>  - Merge remote-tracking branch 'upstream/master' into JDK-8293786
>>  - 8293786: HttpClient will not send more than 64 kb of data from the 2nd request in http2
>
> test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServerConnection.java line 735:
> 
>> 733:                 // isEof() for if END_STREAM has been seen.
>> 734:                 // q.size() > 0 for if frames in Queue have not been read.
>> 735:                 if (bis instanceof BodyInputStream inputStream && (!inputStream.isEof() || inputStream.q.size() > 0)) {
> 
> Caught an error with this code here when `bis` is assigned to `NullInputStream.INSTANCE` above. Need to put in an additional check for that.

On review, issue I saw may have been due to using an out of date build while running test tiers and httpclient tests. Will test further but it seems there is no issue. Especially considering the `instanceof` check should be false and the inner code is skipped.

-------------

PR: https://git.openjdk.org/jdk/pull/12694