RFR: 8303682: Simplify HttpClient DebugLogger

[Jaikiran Pai]

On Tue, 7 Mar 2023 10:16:24 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

> The HttpClient internal DebugLogger could be simplified if its configuration was held in a record. Some of the methods in Utils that return a debug logger could also be simplified/removed. The system property that configures the debug logging could be extended to choose between System.err, System.out, System.Logger, or any of these configurations.
> Passing -Djdk.internal.httpclient.debug=true still works as before.

src/java.net.http/share/classes/jdk/internal/net/http/common/DebugLogger.java line 122:

> 120:             new DebugLogger(HTTP, "WS"::toString, LoggerConfig.OFF);
> 121:     private static final DebugLogger NO_HPACK_LOGGER =
> 122:             new DebugLogger(HTTP, "HPACK"::toString, LoggerConfig.OFF);

Not because of this PR, but I think the NO_WS_LOGGER and the NO_HPACK_LOGGER have a typo/bug in the `System.Logger`, they are using. I think the NO_WS_LOGGER should be:

new DebugLogger(WS, "WS"::toString, LoggerConfig.OFF);

and the NO_HPACK_LOGGER should be:


new DebugLogger(HPACK, "HPACK"::toString, LoggerConfig.OFF);

-------------

PR: https://git.openjdk.org/jdk/pull/12900