RFR: 8303682: Simplify HttpClient DebugLogger [v2]

[Jaikiran Pai]

On Wed, 8 Mar 2023 11:25:43 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> The HttpClient internal DebugLogger could be simplified if its configuration was held in a record. Some of the methods in Utils that return a debug logger could also be simplified/removed. The system property that configures the debug logging could be extended to choose between System.err, System.out, System.Logger, or any of these configurations.
>> Passing -Djdk.internal.httpclient.debug=true still works as before.
>
> Daniel Fuchs has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Make sure julLogger is not GC'ed before the end of the test.
>  - Integrated review feedback

test/jdk/java/net/httpclient/DebugLoggerTest.java line 289:

> 287:         if (dest.contains(Destination.ERR)) {
> 288:             if (!errStr.contains(msg)) {
> 289:                 throw new AssertionError("stderr does not contain the expected message");

Do you think we should print the errStr/outStr/logs in these assertion failure messages, to help debug any failures?

-------------

PR: https://git.openjdk.org/jdk/pull/12900