RFR: 8303485: Replacing os.name for operating system customization
Alan Bateman
alanb at openjdk.org
Fri Mar 10 14:04:27 UTC 2023
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
> Improvements to support OS specific customization for JDK internal use:
> - To select values and code; allowing elimination of unused code and values
> - Optionally evaluated by build processes, compilation, or archiving (i.e. CDS)
> - Simple API to replace adhoc comparisons with `os.name`
> - Clear and consistent use across build, runtime, and JDK modules
>
> The PR includes updates within java.base to use the new API.
src/java.base/share/classes/java/util/zip/ZipFile.java line 28:
> 26: package java.util.zip;
> 27:
> 28: import jdk.internal.misc.OperatingSystem;
You might want to move this to be with the other imports of jdk.internal.
src/java.base/share/classes/jdk/internal/misc/OperatingSystem.java line 23:
> 21: * questions.
> 22: */
> 23: package jdk.internal.misc;
I see there is a follow on PR to see this in several modules. We can't have jdk.internal.misc exported widely as it contains Unsafe and several other important classes. jdk.internal.util may be a better place, at the same of turning that package into a place for random stuff.
-------------
PR: https://git.openjdk.org/jdk/pull/12931
More information about the net-dev
mailing list