RFR: 8303485: Replacing os.name for operating system customization [v2]
Michael Osipov
duke at openjdk.org
Sun Mar 12 14:00:26 UTC 2023
On Fri, 10 Mar 2023 21:21:56 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Improvements to support OS specific customization for JDK internal use:
>> - To select values and code; allowing elimination of unused code and values
>> - Optionally evaluated by build processes, compilation, or archiving (i.e. CDS)
>> - Simple API to replace adhoc comparisons with `os.name`
>> - Clear and consistent use across build, runtime, and JDK modules
>>
>> The PR includes updates within java.base to use the new API.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>
> Move OperatingSystem from jdk.internal.misc to jdk.internal.util
> Rename Mac -> MacOS; isMac() -> isMacOS()
This looks wrong because it would leave out a lot of ports which this solution cannot cover. Rephrased: An exhaustive list of values to an non-exhaustive amount of systems just feels wrong.
-------------
PR: https://git.openjdk.org/jdk/pull/12931
More information about the net-dev
mailing list