RFR: 8267140: Support closing the HttpClient by making it auto-closable

Daniel Fuchs dfuchs at openjdk.org
Tue Mar 14 19:14:34 UTC 2023


On Tue, 14 Mar 2023 14:18:49 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

> Please find here an RFE that makes the `java.net.HttpClient` auto-closeable.
> 
> The API has been modeled on `ExecutorService`.
> 
> HttpClient::close() is a graceful shutdown and will wait until all operations are terminated before returning.
> If a request is in progress, and the caller doesn't pull the corresponding data (for instance, the request was sent with a BodyHandler.ofInputStream(), but the caller stopped reading the input stream) then close() may never return.
> 
> Therefore, additional methods similar to those present in `ExecutorService` are also proposed. In summary:
> 
> - `shutdown()`: initiate a graceful shutdown, but doesn't wait for termination. 
> - `shutdownNow()`:  initiate an immediate shutdown, attempting to cancel all operations in progress. Doesn't wait for termination.
> - `awaitTermination(Duration)`: await for termination within the given delay
> - `isTerminated()` tells whether the client is terminated
> 
> New tests have been added to test the proposed behaviors.
> 
> HttpClient tests (new and old) are still stable.

Here is the CSR draft: https://bugs.openjdk.org/browse/JDK-8304165

-------------

PR: https://git.openjdk.org/jdk/pull/13019


More information about the net-dev mailing list