RFR: 8267140: Support closing the HttpClient by making it auto-closable [v4]
Daniel Fuchs
dfuchs at openjdk.org
Mon Mar 20 10:57:05 UTC 2023
> Please find here an RFE that makes the `java.net.HttpClient` auto-closeable.
>
> The API has been modeled on `ExecutorService`.
>
> HttpClient::close() is a graceful shutdown and will wait until all operations are terminated before returning.
> If a request is in progress, and the caller doesn't pull the corresponding data (for instance, the request was sent with a BodyHandler.ofInputStream(), but the caller stopped reading the input stream) then close() may never return.
>
> Therefore, additional methods similar to those present in `ExecutorService` are also proposed. In summary:
>
> - `shutdown()`: initiate a graceful shutdown, but doesn't wait for termination.
> - `shutdownNow()`: initiate an immediate shutdown, attempting to cancel all operations in progress. Doesn't wait for termination.
> - `awaitTermination(Duration)`: await for termination within the given delay
> - `isTerminated()` tells whether the client is terminated
>
> New tests have been added to test the proposed behaviors.
>
> HttpClient tests (new and old) are still stable.
Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
- Merge branch 'master' into HttpClient-close-8267140
- Update test/jdk/java/net/httpclient/HttpClientShutdown.java
Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
- Update test/jdk/java/net/httpclient/ShutdownNow.java
Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
- Update test/jdk/java/net/httpclient/HttpClientShutdown.java
Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
- Update test/jdk/java/net/httpclient/AsyncShutdownNow.java
Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
- Review feedback
- typo
- Merge branch 'master' into HttpClient-close-8267140
- Throw NPE if duration is null
- 8267140
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/13019/files
- new: https://git.openjdk.org/jdk/pull/13019/files/31b5e3fc..631dd3ea
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=13019&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=13019&range=02-03
Stats: 71955 lines in 666 files changed: 45999 ins; 18002 del; 7954 mod
Patch: https://git.openjdk.org/jdk/pull/13019.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/13019/head:pull/13019
PR: https://git.openjdk.org/jdk/pull/13019
More information about the net-dev
mailing list