RFR: 8267140: Support closing the HttpClient by making it auto-closable [v3]

Daniel Fuchs dfuchs at openjdk.org
Mon Mar 20 10:57:10 UTC 2023


On Mon, 20 Mar 2023 09:48:41 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   typo
>
> src/java.net.http/share/classes/java/net/http/HttpClient.java line 816:
> 
>> 814:      * @since 21
>> 815:      */
>> 816:     public void shutdownNow() {
> 
> The first sentence of the `shutdownNow` api doc should describe the behavior of the method itself, ie that it does an immediate shutdown.
> 
> Also, I wonder if there is another way to formulate these implSpec comments? Naive readers might think they have to override the method.

I have added some text to the `@apiNote` and added a link in all the `@implSpec`. Does that read better?

-------------

PR: https://git.openjdk.org/jdk/pull/13019


More information about the net-dev mailing list