RFR: 8304286: java/net/SocketOption/OptionsTest.java failing after JDK-8302659 [v2]

Daniel Jeliński djelinski at openjdk.org
Mon Mar 20 11:33:08 UTC 2023


> Please review this change that fixes and reenables OptionsTest on Windows.
> 
> The test is checking that the values retrieved from getOption match the values set by an earlier call to setOption. The `IP_MULTICAST_IF` option was tested with the first network interface for which `supportsMulticast` returned true. JDK-8302659 changed the network interface iteration order and the test started failing.
> 
> The proposed change is to verify if the interface is actually usable for multicasting before using it in set/get test. Test passed on all platforms.

Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:

  Change interface selection

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13061/files
  - new: https://git.openjdk.org/jdk/pull/13061/files/078603de..5ccf834a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13061&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13061&range=00-01

  Stats: 8 lines in 2 files changed: 0 ins; 5 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/13061.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/13061/head:pull/13061

PR: https://git.openjdk.org/jdk/pull/13061


More information about the net-dev mailing list