RFR: 8267140: Support closing the HttpClient by making it auto-closable [v4]
Daniel Fuchs
dfuchs at openjdk.org
Mon Mar 20 13:46:06 UTC 2023
On Mon, 20 Mar 2023 12:37:35 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>>
>> - Merge branch 'master' into HttpClient-close-8267140
>> - Update test/jdk/java/net/httpclient/HttpClientShutdown.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - Update test/jdk/java/net/httpclient/ShutdownNow.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - Update test/jdk/java/net/httpclient/HttpClientShutdown.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - Update test/jdk/java/net/httpclient/AsyncShutdownNow.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - Review feedback
>> - typo
>> - Merge branch 'master' into HttpClient-close-8267140
>> - Throw NPE if duration is null
>> - 8267140
>
> src/java.net.http/share/classes/java/net/http/HttpClient.java line 140:
>
>> 138: * connections, which it can typically reuse when another request is made to
>> 139: * the same origin server using the same protocol version and security,
>> 140: * through the same client. In the JDK implementation, connection pools
>
> Hello Daniel, do you think we should maybe skip these details on how the connection pool decides to use a connection from pool? Perhaps, just make a mention that the HttpClient instance manages connections in a pool and may reuse it as and when necessary?
OK
-------------
PR: https://git.openjdk.org/jdk/pull/13019
More information about the net-dev
mailing list