RFR: 8267140: Support closing the HttpClient by making it auto-closable [v4]
Daniel Fuchs
dfuchs at openjdk.org
Mon Mar 20 14:43:01 UTC 2023
On Mon, 20 Mar 2023 13:22:43 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>>
>> - Merge branch 'master' into HttpClient-close-8267140
>> - Update test/jdk/java/net/httpclient/HttpClientShutdown.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - Update test/jdk/java/net/httpclient/ShutdownNow.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - Update test/jdk/java/net/httpclient/HttpClientShutdown.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - Update test/jdk/java/net/httpclient/AsyncShutdownNow.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - Review feedback
>> - typo
>> - Merge branch 'master' into HttpClient-close-8267140
>> - Throw NPE if duration is null
>> - 8267140
>
> With the introduction of closing a HttpClient, should the API set any expectations about how the instance level methods behave when they are invoked on a terminated client or on a client which is in the process of being terminated?
@jaikiran I have pushed the updates to the spec. I will update the CSR.
-------------
PR: https://git.openjdk.org/jdk/pull/13019
More information about the net-dev
mailing list