RFR: 8304286: java/net/SocketOption/OptionsTest.java failing after JDK-8302659 [v2]
Daniel Jeliński
djelinski at openjdk.org
Mon Mar 20 17:55:46 UTC 2023
On Mon, 20 Mar 2023 11:33:08 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
>> Please review this change that fixes and reenables OptionsTest on Windows.
>>
>> The test is checking that the values retrieved from getOption match the values set by an earlier call to setOption. The `IP_MULTICAST_IF` option was tested with the first network interface for which `supportsMulticast` returned true. JDK-8302659 changed the network interface iteration order and the test started failing.
>>
>> The proposed change is to verify if the interface is actually usable for multicasting before using it in set/get test. Test passed on all platforms.
>
> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
>
> Change interface selection
using `NetworkConfiguration` required some more changes; let me know if that's what you had in mind.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13061#issuecomment-1476684774
More information about the net-dev
mailing list