RFR: 8267140: Support closing the HttpClient by making it auto-closable [v9]

[Jaikiran Pai]

On Mon, 20 Mar 2023 18:42:23 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Please find here an RFE that makes the `java.net.HttpClient` auto-closeable.
>> 
>> The API has been modeled on `ExecutorService`.
>> 
>> HttpClient::close() is a graceful shutdown and will wait until all operations are terminated before returning.
>> If a request is in progress, and the caller doesn't pull the corresponding data (for instance, the request was sent with a BodyHandler.ofInputStream(), but the caller stopped reading the input stream) then close() may never return.
>> 
>> Therefore, additional methods similar to those present in `ExecutorService` are also proposed. In summary:
>> 
>> - `shutdown()`: initiate a graceful shutdown, but doesn't wait for termination. 
>> - `shutdownNow()`:  initiate an immediate shutdown, attempting to cancel all operations in progress. Doesn't wait for termination.
>> - `awaitTermination(Duration)`: await for termination within the given delay
>> - `isTerminated()` tells whether the client is terminated
>> 
>> New tests have been added to test the proposed behaviors.
>> 
>> HttpClient tests (new and old) are still stable.
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add tests for default method implementations; Refactor HttpClientBuilderTest to close the clients it creates

src/java.net.http/share/classes/java/net/http/HttpClient.java line 664:

> 662:      * <ul>
> 663:      * <li>{@link IOException} - if an I/O error occurs when sending or receiving,
> 664:      *      or the client {@linkplain ##closing shutting down}.</li>

Hello Daniel, there's a "is" missing here. Should have been "client is ..."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13019#discussion_r1143139209