RFR: 8267140: Support closing the HttpClient by making it auto-closable [v11]
Jaikiran Pai
jpai at openjdk.org
Thu Mar 23 07:29:50 UTC 2023
On Wed, 22 Mar 2023 11:15:38 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Please find here an RFE that makes the `java.net.HttpClient` auto-closeable.
>>
>> The API has been modeled on `ExecutorService`.
>>
>> HttpClient::close() is a graceful shutdown and will wait until all operations are terminated before returning.
>> If a request is in progress, and the caller doesn't pull the corresponding data (for instance, the request was sent with a BodyHandler.ofInputStream(), but the caller stopped reading the input stream) then close() may never return.
>>
>> Therefore, additional methods similar to those present in `ExecutorService` are also proposed. In summary:
>>
>> - `shutdown()`: initiate a graceful shutdown, but doesn't wait for termination.
>> - `shutdownNow()`: initiate an immediate shutdown, attempting to cancel all operations in progress. Doesn't wait for termination.
>> - `awaitTermination(Duration)`: await for termination within the given delay
>> - `isTerminated()` tells whether the client is terminated
>>
>> New tests have been added to test the proposed behaviors.
>>
>> HttpClient tests (new and old) are still stable.
>
> Daniel Fuchs has updated the pull request incrementally with two additional commits since the last revision:
>
> - Minor updates. Added some links
> - Define operations. Clarify some of the things that may stall an orderly shutdown
test/jdk/java/net/httpclient/HttpClientClose.java line 172:
> 170: }
> 171: if (failed instanceof Exception ex) throw ex;
> 172: if (failed instanceof Error e) throw e;
Is this missing a `client.isTerminated()` assertion here?
test/jdk/java/net/httpclient/HttpClientClose.java line 178:
> 176: try {
> 177: readerService.shutdown();
> 178: readerService.awaitTermination(2000, TimeUnit.MILLISECONDS);
Same comment about the timeout value.
test/jdk/java/net/httpclient/HttpClientClose.java line 298:
> 296: String msg = "Incorrect uuid header values:[" + uuids + "]";
> 297: (new RuntimeException(msg)).printStackTrace();
> 298: t.sendResponseHeaders(500, -1);
Same comment about the `-1` value.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13019#discussion_r1145779274
PR Review Comment: https://git.openjdk.org/jdk/pull/13019#discussion_r1145779410
PR Review Comment: https://git.openjdk.org/jdk/pull/13019#discussion_r1145779779
More information about the net-dev
mailing list