RFR: 8267140: Support closing the HttpClient by making it auto-closable [v11]

Jaikiran Pai jpai at openjdk.org
Thu Mar 23 13:32:45 UTC 2023


On Thu, 23 Mar 2023 09:25:51 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> We have called `shutdownNow` and at this point we have already waited until all completable futures have been terminated, so hopefully there should not be long to wait. If there is, it might indicate a bug - for instance that the SelectorManager thread was not woken properly. So I'd rather keep the 2s for now - see if it causes trouble. It hasn't in my numerous test runs, but yes - I haven't run this test with -Xint or -Xcomp in debug builds...
>
> If it fails I'd like to do some analysis of the logs before just increasing the timeout.

That sounds reasonable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13019#discussion_r1146200957


More information about the net-dev mailing list