RFR: 7026262: HttpServer: improve handling of finished HTTP exchanges

[Daniel Jeliński]

On Thu, 23 Mar 2023 18:08:41 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> This patch fixes the following issues with HttpHandler exception handling:
>> - The connection is no longer closed if an exception is thrown after the response is completed. As soon as the response is completed, the connection is added back to the pool, ready for reuse. Closing the connection would race with the subsequent handler.
>> - The stream returned by `getResponseBody` is now usable even if the response has zero-length body. Writing any data to the stream will still fail, but zero-length writes and closing the stream will now succeed.
>> - `ServerImpl.Exchange.reject` now sends a `Connection: close` header in addition to closing the connection
>> 
>> The test `B8293562` had to be adjusted to avoid `Connection: close`.
>> Additionally, while I was looking for a good test to copy from, I found and fixed a bug in test `B5045306`.
>> 
>> The new tests are passing with this patch, failing without it. Tier 1-3 clean.
>
> src/jdk.httpserver/share/classes/sun/net/httpserver/ServerImpl.java line 881:
> 
>> 879:                 code, true, "<h1>"+code+Code.msg(code)+"</h1>"+message
>> 880:             );
>> 881:             closeConnection(connection);
> 
> Looks like this line (881) is now redundant, since `sendReply(code, true, ...)` will close the connection?

Good point. Will remove.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13157#discussion_r1147208183