Integrated: 7026262: HttpServer: improve handling of finished HTTP exchanges

Daniel Jeliński djelinski at openjdk.org
Mon Mar 27 05:25:44 UTC 2023


On Thu, 23 Mar 2023 11:33:32 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> This patch fixes the following issues with HttpHandler exception handling:
> - The connection is no longer closed if an exception is thrown after the response is completed. As soon as the response is completed, the connection is added back to the pool, ready for reuse. Closing the connection would race with the subsequent handler.
> - The stream returned by `getResponseBody` is now usable even if the response has zero-length body. Writing any data to the stream will still fail, but zero-length writes and closing the stream will now succeed.
> - `ServerImpl.Exchange.reject` now sends a `Connection: close` header in addition to closing the connection
> 
> The test `B8293562` had to be adjusted to avoid `Connection: close`.
> Additionally, while I was looking for a good test to copy from, I found and fixed a bug in test `B5045306`.
> 
> The new tests are passing with this patch, failing without it. Tier 1-3 clean.

This pull request has now been integrated.

Changeset: a5ffa079
Author:    Daniel Jeliński <djelinski at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a5ffa079a0d6107be652bc026f5c91b7dcd791f8
Stats:     325 lines in 9 files changed: 288 ins; 19 del; 18 mod

7026262: HttpServer: improve handling of finished HTTP exchanges

Reviewed-by: dfuchs, michaelm

-------------

PR: https://git.openjdk.org/jdk/pull/13157


More information about the net-dev mailing list