RFR: 8304818: Prune HttpURLConnection cache when corresponding Authenticator is garbage collected [v2]
Andrey Turbanov
aturbanov at openjdk.org
Mon Mar 27 07:58:33 UTC 2023
On Fri, 24 Mar 2023 16:39:41 GMT, Michael McMahon <michaelm at openjdk.org> wrote:
>> Hi,
>>
>> Can I get a review for this please? This change uses a Cleaner to check when java.net.Authenticator instances become unreachable, and then prunes the authentication cache for entries that correspond to that Authenticator and therefore cannot be used again. This stops the authentication cache from growing in size unbounded. Note, this only happens in the probably unusual case where more than one Authenticator object is used. Normally there is no reason to use more than one instance.
>>
>> Thanks,
>> Michael.
>
> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
>
> test update
src/java.base/share/classes/sun/net/www/protocol/http/AuthCacheImpl.java line 81:
> 79:
> 80: public void run() {
> 81: synchronized(AuthCacheImpl.this) {
Suggestion:
synchronized (AuthCacheImpl.this) {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13159#discussion_r1148924604
More information about the net-dev
mailing list