RFR: 8304818: Prune HttpURLConnection cache when corresponding Authenticator is garbage collected [v3]

Andrey Turbanov aturbanov at openjdk.org
Mon Mar 27 11:22:34 UTC 2023


On Mon, 27 Mar 2023 09:05:17 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Hi,
>> 
>> Can I get a review for this please? This change uses a Cleaner to check when java.net.Authenticator instances become unreachable, and then prunes the authentication cache for entries that correspond to that Authenticator and therefore cannot be used again. This stops the authentication cache from growing in size unbounded. Note, this only happens in the probably unusual case where more than one Authenticator object is used. Normally there is no reason to use more than one instance.
>> 
>> Thanks,
>> Michael.
>
> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review updates

test/jdk/sun/net/www/protocol/http/AuthCache.java line 52:

> 50:         private final String username;
> 51:         private final String password;
> 52:         private AtomicBoolean wasCalled = new AtomicBoolean();

`wasCalled` is accessed only from `synchronized` methods. We can use plain `boolean` instead

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13159#discussion_r1149165113


More information about the net-dev mailing list