RFR: 8304927: Update java/net/httpclient/BasicAuthTest.java to check basic auth over HTTP/2 [v2]

Daniel Fuchs dfuchs at openjdk.org
Tue Mar 28 16:32:37 UTC 2023


On Tue, 28 Mar 2023 07:03:49 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added ca.count in exception message
>
> test/jdk/java/net/httpclient/BasicAuthTest.java line 115:
> 
>> 113: 
>> 114:             if (!ok || ca.count != 1)
>> 115:                 throw new RuntimeException("Test failed");
> 
> Hello Daniel, while we are changing this test, do you think we should also update this exception message, here and other places where we throw this, to also include the `ca.count` in the exception message to help debug any potential failures?

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13189#discussion_r1150879107


More information about the net-dev mailing list