RFR: 8267140: Support closing the HttpClient by making it auto-closable [v14]

Daniel Fuchs dfuchs at openjdk.org
Tue Mar 28 19:01:38 UTC 2023


> Please find here an RFE that makes the `java.net.HttpClient` auto-closeable.
> 
> The API has been modeled on `ExecutorService`.
> 
> HttpClient::close() is a graceful shutdown and will wait until all operations are terminated before returning.
> If a request is in progress, and the caller doesn't pull the corresponding data (for instance, the request was sent with a BodyHandler.ofInputStream(), but the caller stopped reading the input stream) then close() may never return.
> 
> Therefore, additional methods similar to those present in `ExecutorService` are also proposed. In summary:
> 
> - `shutdown()`: initiate a graceful shutdown, but doesn't wait for termination. 
> - `shutdownNow()`:  initiate an immediate shutdown, attempting to cancel all operations in progress. Doesn't wait for termination.
> - `awaitTermination(Duration)`: await for termination within the given delay
> - `isTerminated()` tells whether the client is terminated
> 
> New tests have been added to test the proposed behaviors.
> 
> HttpClient tests (new and old) are still stable.

Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 21 additional commits since the last revision:

 - Merge branch 'master' into HttpClient-close-8267140
 - Fixed minor typos in test comments
 - Integrated feedback on tests
 - Minor updates. Added some links
 - Define operations. Clarify some of the things that may stall an orderly shutdown
 - Update src/java.net.http/share/classes/java/net/http/HttpClient.java
   
   Fixed typo
 - Add tests for default method implementations; Refactor HttpClientBuilderTest to close the clients it creates
 - Rephrase IOException in send/sendAsync
 - Added missing linkplain
 - Specify that IOException is thrown if the client is terminated
 - ... and 11 more: https://git.openjdk.org/jdk/compare/d6c93ecc...e6abd08b

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13019/files
  - new: https://git.openjdk.org/jdk/pull/13019/files/01142a2d..e6abd08b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13019&range=13
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13019&range=12-13

  Stats: 17745 lines in 537 files changed: 7536 ins; 7237 del; 2972 mod
  Patch: https://git.openjdk.org/jdk/pull/13019.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13019/head:pull/13019

PR: https://git.openjdk.org/jdk/pull/13019


More information about the net-dev mailing list