RFR: 8054022: HttpURLConnection timeouts with Expect: 100-Continue and no chunking [v4]

Daniel Fuchs dfuchs at openjdk.org
Wed May 3 12:46:18 UTC 2023


On Wed, 3 May 2023 11:47:13 GMT, Darragh Clarke <duke at openjdk.org> wrote:

>> Currently it is possible for `HttpURLConnection` with the `Expect: 100-Continue` header to timeout awaiting for a server response. According to [RFC-7231](https://www.rfc-editor.org/rfc/rfc7231#section-5.1.1) a client `SHOULD NOT wait for an indefinite period before sending the message body`.
>> 
>> This PR changes the existing `expect100Continue` method to wait for a maximum of 5 seconds for a server response, this will be shorter if a timeout is set. If no response is received, the message is sent regardless.
>> 
>> Tests have been added to account for different scenarios that currently timeout, and the changes have been tested against tiers 1,2 and 3.
>
> Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Apply suggestions from code review
>   
>   Co-authored-by: Daniel Fuchs <67001856+dfuch at users.noreply.github.com>

LGTM

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13330#pullrequestreview-1410812161


More information about the net-dev mailing list