RFR: 8304885: Reuse stale data to improve DNS resolver resiliency [v7]

Sergey Bylokhov serb at openjdk.org
Wed May 10 22:10:43 UTC 2023


On Tue, 9 May 2023 13:56:34 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> src/java.base/share/classes/java/net/doc-files/net-properties.html line 276:
>> 
>>> 274: 	preferable to use a stale name rather than result of unsuccessful name lookup.
>>> 275: 	A value of 0 (zero) means do not use stale names.
>>> 276: 	The default value is implementation-specific.</P>
>> 
>> Suggestion:
>> 
>> 	A value of 0 (zero) or if the property is not set means do not use stale names.
>> 	By default, the property is not set.</P>
>
> We probably should specify what happens if the stale property is negative. Looks like it might be ignored, which I guess is okay.

I have update the text about "property is not set" case, but leave the text about "default value" as implementation-specific, similarly to what we have in the text about "networkaddress.cache.ttl" property, and this allow to change this value in some situations.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13285#discussion_r1190434251


More information about the net-dev mailing list