RFR: 8307626: java/net/httpclient/FlowAdapter* tests should close the HttpClient instances

Jaikiran Pai jpai at openjdk.org
Thu May 11 05:51:40 UTC 2023


On Wed, 10 May 2023 16:19:00 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

> java/net/httpclient/FlowAdapterPublisherTest.java and java/net/httpclient/FlowAdapterSubscriberTest.java create one HttpClient instance per test method. The test should use try-with-resources to close the client instances.

test/jdk/java/net/httpclient/FlowAdapterPublisherTest.java line 100:

> 98:     }
> 99: 
> 100:     private HttpClient newHttpClient(String uri) {

Hello Daniel, the `uri` param doesn't seem to be used in this method. 

Same in the other test class.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13909#discussion_r1190662233


More information about the net-dev mailing list