RFR: 8308185: Update Http2TestServerConnection to use SSLSocket.startHandshake()

Daniel Jeliński djelinski at openjdk.org
Tue May 16 15:20:47 UTC 2023


On Tue, 16 May 2023 13:36:15 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change in the `jdk.httpclient.test.lib.http2.Http2TestServerConnection` which proposes to use the `SSLSocket.startHandshake()`  to API propogate any handshake exception back to the test that uses this test server?
> 
> This addresses https://bugs.openjdk.org/browse/JDK-8308185 and as noted in that JBS issue should help diagnoze any handshake failures in httpclient tests, a bit more easily.
> 
> tier2 testing with this change came back without any failures.

Marked as reviewed by djelinski (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/14012#pullrequestreview-1428839682


More information about the net-dev mailing list