RFR: 8308310: HttpClient: Avoid logging or locking from within synchronized blocks [v5]

Daniel Fuchs dfuchs at openjdk.org
Thu May 18 16:47:13 UTC 2023


On Thu, 18 May 2023 16:10:32 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add debug traces to ExpectContinueTest.java
>
> src/java.net.http/share/classes/jdk/internal/net/http/Stream.java line 154:
> 
>> 152:     // send lock: prevent sending DataFrames after reset occurred.
>> 153:     private final Lock sendLock = new ReentrantLock();
>> 154:     final Lock stateLock = new ReentrantLock();
> 
> can it be `private` too?

Good point

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14038#discussion_r1198042636


More information about the net-dev mailing list