RFR: 8308310: HttpClient: Avoid logging or locking from within synchronized blocks [v10]
Daniel Fuchs
dfuchs at openjdk.org
Wed May 24 13:01:31 UTC 2023
> Please find here a change that revisits usage of monitors in the HttpClient.
>
> With Virtual Threads now part of the platform it should be possible to pass a newVirtualThreadPerTaskExecutor to the HttpClient. Logging, when enabled, and when called from a synchronized block, can cause the carrier thread to get pinned in case of contention when printing through the underlying PrintStream.
>
> This change aims at avoiding situations where the carrier threads might get pinned.
Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
More review feedback
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/14038/files
- new: https://git.openjdk.org/jdk/pull/14038/files/f5986f93..0f34be9a
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=14038&range=09
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=14038&range=08-09
Stats: 69 lines in 1 file changed: 31 ins; 26 del; 12 mod
Patch: https://git.openjdk.org/jdk/pull/14038.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14038/head:pull/14038
PR: https://git.openjdk.org/jdk/pull/14038
More information about the net-dev
mailing list