RFR: 8308310: HttpClient: Avoid logging or locking from within synchronized blocks [v8]

[Daniel Fuchs]

On Wed, 24 May 2023 11:40:42 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
>> 
>>  - Merge branch 'master' into HttpClient-Logging-8308310
>>  - Merge branch 'master' into HttpClient-Logging-8308310
>>  - Fix whitespace
>>  - make stateLock final
>>  - Add debug traces to ExpectContinueTest.java
>>  - failedRef should be final
>>  - Align parameters
>>  - Update src/java.net.http/share/classes/jdk/internal/net/http/Http1Response.java
>>    
>>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>>  - Update src/java.net.http/share/classes/jdk/internal/net/http/ConnectionPool.java
>>    
>>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>>  - Update test/jdk/java/net/httpclient/AuthFilterCacheTest.java
>>    
>>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>>  - ... and 1 more: https://git.openjdk.org/jdk/compare/c0c4d771...c5d2f1f2
>
> test/jdk/java/net/httpclient/ConcurrentResponses.java line 182:
> 
>> 180:                 .join();
>> 181:         client.close();
>> 182:         virtualExecutor.close();
> 
> Could we do this in a try/finally block? Same for the other test method.

Done. Note that I avoided try-with-resource in order to ensure that the client would be closed first.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14038#discussion_r1204108668