RFR: 8305763 : Parsing a URI with an underscore goes through a silent exception, negatively impacting performance [v2]
    Dhamoder Nalla 
    duke at openjdk.org
       
    Wed May 24 22:16:20 UTC 2023
    
    
  
On Wed, 24 May 2023 13:19:10 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Dhamoder Nalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressing CR comments
>
> src/java.base/share/classes/java/net/URI.java line 3314:
> 
>> 3312:                             failExpecting("end of authority", q);
>> 3313:                     } else
>> 3314:                         authority = input.substring(p, n);
> 
> Suggestion:
> 
>                         } else {
>                             failExpecting("end of authority", q);
>                         }
>                     } else {
>                         authority = input.substring(p, n);
>                     }
Thank you @dfuch
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13430#discussion_r1204807611
    
    
More information about the net-dev
mailing list