RFR: 8305763 : Parsing a URI with an underscore goes through a silent exception, negatively impacting performance [v3]

Dhamoder Nalla duke at openjdk.org
Thu May 25 19:34:36 UTC 2023


On Thu, 25 May 2023 10:26:27 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Dhamoder Nalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address CR comments
>
> src/java.base/share/classes/java/net/URI.java line 3306:
> 
>> 3304:                     q = parseServer(p, n, skipParseException);
>> 3305:                     if (q < n) {
>> 3306:                         if(skipParseException) {
> 
> Suggestion:
> 
>                         if (skipParseException) {

Thanks for reviewing the PR @turbanoff

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13430#discussion_r1205927755


More information about the net-dev mailing list