RFR: 8304885: Reuse stale data to improve DNS resolver resiliency [v11]

Mon May 29 16:13:59 UTC 2023

On Mon, 29 May 2023 13:16:07 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   if the property is not set means do not use stale names
>
> src/java.base/share/classes/java/net/doc-files/net-properties.html line 277:
> 
>> 275: 	A value of 0 (zero) or if the property is not set means do not use stale
>> 276: 	names, the negative value is ignored.
>> 277: 	The default value is implementation-specific.</P>
> 
> Maybe we should say that the default value is 0 since this is what is documented in `java.security`

In the "java.security" file we documented the default value of the property in that file but it is commented out. Right now the new property specified in the same way as the old "networkaddress.cache.ttl", see [net-properties.html](https://github.com/openjdk/jdk/pull/13285/files/ce595f74f511553274c9da254d53b368abe44408#diff-21ffe1f9a665c0f70cc9888d2da937a2a77fadfdacc23d0bd59506595e668c5fR267) and [InetAddress.java](https://github.com/openjdk/jdk/pull/13285/files/a856cd36eba1efacbc0f95918ac6aa2712cab870#diff-55d4acc64110543896bf6c289d6247cded986edfe9ccce3a9bca88a197711d58R204)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13285#discussion_r1209443997