RFR: 8307648: java/net/httpclient/ExpectContinueTest.java timed out [v2]

[Daniel Jeliński]

On Tue, 30 May 2023 11:57:41 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Please find here a fix for the java/net/httpclient/ExpectContinueTest.java which was failing intermittently.
>> 
>> It turns out there was two bugs here:
>> 
>> - on on the server side, which added the END_STREAM flag to the HeaderFrame containing the 100 response.
>>   This can obviously never be right since 100 is an intermediary response, which should be followed by a final response.
>>   
>> - on the client side, because this was interpreted as "there will be no body" - but it didn't prevent the client from waiting for the final response.
>> 
>> With this fix a 100 response carrying the END_STREAM flag will cause the exchange to be cancelled. I manually verified that this worked before fixing the server side.
>> 
>> The logic on server side is fixed to ignore whatever length is passed to sendResponseHeaders() if 100 is supplied, and to not add the END_STREAM flag to the HeaderFrame that carries the 100 response (which is a side effect of setting the expected length parameter to 0 in that case).
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   A HEADERS frame with the END_STREAM flag set that carries an informational status code is malformed

LGTM.
Given that this alters the client behavior, please add a test or a noreg label.

-------------

Marked as reviewed by djelinski (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14207#pullrequestreview-1450888088