Integrated: 8307648: java/net/httpclient/ExpectContinueTest.java timed out

Daniel Fuchs dfuchs at openjdk.org
Tue May 30 16:35:04 UTC 2023


On Mon, 29 May 2023 17:10:14 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

> Please find here a fix for the java/net/httpclient/ExpectContinueTest.java which was failing intermittently.
> 
> It turns out there was two bugs here:
> 
> - on on the server side, which added the END_STREAM flag to the HeaderFrame containing the 100 response.
>   This can obviously never be right since 100 is an intermediary response, which should be followed by a final response.
>   
> - on the client side, because this was interpreted as "there will be no body" - but it didn't prevent the client from waiting for the final response.
> 
> With this fix a 100 response carrying the END_STREAM flag will cause the exchange to be cancelled. I manually verified that this worked before fixing the server side.
> 
> The logic on server side is fixed to ignore whatever length is passed to sendResponseHeaders() if 100 is supplied, and to not add the END_STREAM flag to the HeaderFrame that carries the 100 response (which is a side effect of setting the expected length parameter to 0 in that case).

This pull request has now been integrated.

Changeset: 04b0e785
Author:    Daniel Fuchs <dfuchs at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/04b0e785f6b9b4629b77bb19f2b072434be4951c
Stats:     68 lines in 3 files changed: 58 ins; 0 del; 10 mod

8307648: java/net/httpclient/ExpectContinueTest.java timed out

Reviewed-by: djelinski

-------------

PR: https://git.openjdk.org/jdk/pull/14207


More information about the net-dev mailing list