RFR: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader [v2]

[Jaikiran Pai]

On Fri, 17 Nov 2023 11:31:58 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review suggestion - improve the diagram
>
> src/java.net.http/share/classes/jdk/internal/net/http/common/SSLFlowDelegate.java line 99:
> 
>> 97:  *              |   downWriter                          |   downReader
>> 98:  *              | supplied to constructor               |  supplied to constructor
>> 99:  *              v                                       v
> 
> Can we keep the original diagram too? The new diagram is very nice but gives the impression that encrypt/decrypt are completely independent threads of execution and they're not - since consuming some data may probe the engine to request sending of some data.

Hello Daniel, I've updated the PR to slightly improve the current proposed form to address the part that the encrypt/decrypt are independent. To me, the old diagram wasn't clear enough on what represented upstream/downstream (given that the directions were horizontal), plus what kind of data the upstream/downstream received.

Do you think in the updated version of this PR, the diagram addresses this review comment? If not, I'll update the PR further to include the original diagram too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16704#discussion_r1398671280