RFR: 8316734: URLEncoder should specify that replacement bytes will be used in case of coding error

Daniel Fuchs dfuchs at openjdk.org
Mon Nov 20 15:05:51 UTC 2023


On Mon, 20 Nov 2023 14:29:49 GMT, Darragh Clarke <dclarke at openjdk.org> wrote:

>>> That's a good point. I see that there's another `decode(String, String)` method above in this file that has the same old `@implNote` but not `@throws`. Maybe the implNote should be removed there too and the `@throws` added. Not sure it's worth touching the first `@Deprecated decode(String)` method though. Opinions?
>> 
>> Since we are editing this method descriptions then it's probably best to add the throws IAE to the other 2-arg decode method. I suppose the 1-arg/deprecated decode method should document the exception too, doesn't need to be done in this PR of course.
>
> I'd be happy to change all in this PR if there are no objections

Yes - let's fix it all here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16709#discussion_r1399333221


More information about the net-dev mailing list