RFR: 8320577: Improve MessageHeader's toString() function to make HttpURLConnection's debug log readable [v2]

Daniel Fuchs dfuchs at openjdk.org
Wed Nov 22 18:28:20 UTC 2023


On Wed, 22 Nov 2023 17:33:21 GMT, Oliver Lockwood <duke at openjdk.org> wrote:

>> At the moment, if you have debug logging turned on for the `HttpURLConnection` class, then from [line 746](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java#L746) a log message like this is generated:
>>> sun.net.www.MessageHeader at 49c4f2906 pairs: {null: HTTP/1.1 200}{Content-Type: application/json}{Transfer-Encoding: chunked}{Date: Thu, 09 Nov 2023 11:50:00 GMT}{Keep-Alive: timeout=60}{Connection: keep-alive}
>> 
>> The lack of separation after the `Object.toString()` output makes it hard to realise from the above that it's trying to say "6 pairs". 
>> The change proposed by this PR would make the same log operation output this, instead:
>>> sun.net.www.MessageHeader at 49c4f290 6 pairs: {null: HTTP/1.1 200}{Content-Type: application/json}{Transfer-Encoding: chunked}{Date: Thu, 09 Nov 2023 11:50:00 GMT}{Keep-Alive: timeout=60}{Connection: keep-alive}
>
> Oliver Lockwood has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Amend copyright header as requested by reviewers

Thanks for the fix! If you need a sponsor, please drop a message here after integrating.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16615#pullrequestreview-1745085157


More information about the net-dev mailing list