RFR: 8314978: Multiple server call from connection failing with expect100 in getOutputStream [v4]
Daniel Fuchs
dfuchs at openjdk.org
Wed Oct 4 16:57:03 UTC 2023
On Wed, 4 Oct 2023 10:38:18 GMT, Vyom Tewari <vtewari at openjdk.org> wrote:
>> With the current implementation of HttpURLConnection if server rejects the “Expect 100-continue” then there will be ‘java.net.ProtocolException’ will be thrown from 'expect100Continue()' method.
>>
>> After the exception thrown, If we call any other method on the same instance (ex getHeaderField(), or getHeaderFields()). They will internally call getOuputStream() which invokes writeRequests(), which make the actual server call.
>>
>> The code change will sets the existing variable ‘rememberedException’ when there is exception and getOutputStream0() will re-throw ‘rememberedException’ if the ‘rememberedException’ is not null.
>>
>> Note: getOutputStream0() also call’s ‘expect100Continue()’ if ‘expectContinue’ is true.
>
> Vyom Tewari has updated the pull request incrementally with one additional commit since the last revision:
>
> addressed the review comment
Marked as reviewed by dfuchs (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/15483#pullrequestreview-1658085707
More information about the net-dev
mailing list