RFR: 8309118: HttpClient: Add more tests for 100 ExpectContinue with HTTP/2 [v3]

Conor Cleary ccleary at openjdk.org
Mon Oct 9 15:44:07 UTC 2023


On Mon, 9 Oct 2023 13:33:03 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Conor Cleary has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - 8309118: Fixed error in handleReset ReentrantLock
>>  - 8309118: Updates to Stream cancelImpl
>>  - 8309118: Refactored test, updated incoming_reset
>>  - Merge branch 'master' into JDK-8309118
>>  - 8309118: Cleanup identifiers and whitespace
>>  - 8309118: Removed unused try-with-resources
>>  - 8309118: Improve comments and annotations
>>  - 8309118: Remove local test timeout value
>>  - 8309118: Add more tests for 100 ExpectContinue with HTTP/2
>
> src/java.net.http/share/classes/jdk/internal/net/http/Stream.java line 484:
> 
>> 482:         if (debug.on()) debug.log("incoming: %s", frame);
>> 483:         var cancelled = checkRequestCancelled() || closed;
>> 484: //        endStreamSeen = endStreamSeen || frame.getFlag(HeaderFrame.END_STREAM);
> 
> leftover to be removed?

Correct, from an older iteration. Will remove

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15664#discussion_r1350471672


More information about the net-dev mailing list