RFR: 8317696: Fix compilation with clang-16 [v3]

Phil Race prr at openjdk.org
Tue Oct 10 20:39:47 UTC 2023


On Mon, 9 Oct 2023 18:29:26 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove declaration changes which are not required
>>    - suggested by djelinski
>
> src/java.desktop/unix/native/common/awt/awt_GraphicsEnv.h line 53:
> 
>> 51: #define MITSHM_PERM_OWNER  (0600)
>> 52: 
>> 53: extern int XShmQueryExtension(Display* dpy);
> 
> I wonder if it's even needed here: the declaration should come from `X11/extensions/XShm.h` which is included.

I agree, but I wonder why it was ever added ? Near as I can tell its been there since the SHM code was added in 1.4

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16092#discussion_r1353307160


More information about the net-dev mailing list