RFR: 8316927: JFR: Move shouldCommit check earlier for socket events
    Tim Prinzing 
    tprinzing at openjdk.org
       
    Thu Oct 12 14:47:38 UTC 2023
    
    
  
On Mon, 25 Sep 2023 16:57:46 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
> Hi,
> 
> The events for socket read and socket write retrieves the remote address even in cases where the event didn't exceed the threshold. By moving the shouldCommit check earlier, it can be avoided. 
> 
> Testing: jdk/jdk/jfr
> 
> Thanks
> Erik
I was planning to change the convenience function to take functions as arguments.  With this change there is a bunch of duplicated code.
I was planning to push the change for JDK-8310978 today, but I guess that will have to wait as it's impacted by this.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15908#issuecomment-1759755174
    
    
More information about the net-dev
mailing list