RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses [v2]

[Daniel Jeliński]

On Mon, 23 Oct 2023 12:24:19 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove redundant checks
>
> src/java.base/share/classes/java/net/SocksSocketImpl.java line 307:
> 
>> 305:                 host = ParseUtil.encodePath(host);
>> 306:             }
>> 307:             // IPv6 literal?
> 
> Hello Daniel, this comment seems to have been misplaced. I think it should have been a few lines above just when `isIPv6LiteralAddress` is being called.

Good catch, this comment doesn't make much sense here. `isIPv6LiteralAddress` is descriptive enough, I'll just remove the comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16265#discussion_r1368741693