RFR: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses [v3]
Daniel Jeliński
djelinski at openjdk.org
Mon Oct 23 14:29:59 UTC 2023
> This patch fixes the encoding of IPv6 addresses in the URI provided to ProxySelector.
>
> The original code percent-encoded the square brackets added around the IPv6 addresses, producing URIs that could not be parsed correctly.
>
> The proposed code does not percent-encode the IPv6 addresses at all.
>
> Added a test to verify that different forms of addresses are processed correctly. The test verifies the handling of IPv4 addresses, IPv6 without scope, IPv6 with numeric scope, IPv6 with textual scope (only if present on the machine running tests), hostnames and FQDNs
>
> Tier1-3 tests passed.
Daniel Jeliński has updated the pull request incrementally with two additional commits since the last revision:
- Run test in othervm
- Remove leftover comment
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/16265/files
- new: https://git.openjdk.org/jdk/pull/16265/files/9e3cd23c..c7ec8eb9
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=16265&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=16265&range=01-02
Stats: 9 lines in 2 files changed: 0 ins; 8 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/16265.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/16265/head:pull/16265
PR: https://git.openjdk.org/jdk/pull/16265
More information about the net-dev
mailing list