Integrated: 8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses
Daniel Jeliński
djelinski at openjdk.org
Tue Oct 24 05:39:46 UTC 2023
On Thu, 19 Oct 2023 12:10:02 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> This patch fixes the encoding of IPv6 addresses in the URI provided to ProxySelector.
>
> The original code percent-encoded the square brackets added around the IPv6 addresses, producing URIs that could not be parsed correctly.
>
> The proposed code does not percent-encode the IPv6 addresses at all.
>
> Added a test to verify that different forms of addresses are processed correctly. The test verifies the handling of IPv4 addresses, IPv6 without scope, IPv6 with numeric scope, IPv6 with textual scope (only if present on the machine running tests), hostnames and FQDNs
>
> Tier1-3 tests passed.
This pull request has now been integrated.
Changeset: 728b858c
Author: Daniel Jeliński <djelinski at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/728b858c787567fa4eed6dd44730dfdb8b30be0f
Stats: 207 lines in 2 files changed: 199 ins; 4 del; 4 mod
8318130: SocksSocketImpl needlessly encodes hostname for IPv6 addresses
Reviewed-by: dfuchs, jpai, aefimov, michaelm
-------------
PR: https://git.openjdk.org/jdk/pull/16265
More information about the net-dev
mailing list