RFR: 8309118: HttpClient: Add more tests for 100 ExpectContinue with HTTP/2 [v6]

Conor Cleary ccleary at openjdk.org
Tue Oct 24 09:38:39 UTC 2023


On Mon, 23 Oct 2023 14:11:50 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Conor Cleary has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   schedule completes normally on NO_ERROR, incoming_reset safely accesses volataile
>
> src/java.net.http/share/classes/jdk/internal/net/http/Stream.java line 619:
> 
>> 617:             }
>> 618:             if (!endStreamSeen) {
>> 619:                 // If no END_STREAM flag seen, any RST_STREAM should be handled here immediately
> 
> Suggestion:
> 
>             if (!endStreamSeen || !finalResponseCodeReceived) {
>                 // If no END_STREAM flag seen, any RST_STREAM should be handled here immediately
>                 // If the final response code was not received, then we should also handle
>                 // the RST_STREAM immediately

So by checking if the final response code is received, this makes sure that the entire block of headers is processed therfore a status code will have been received.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15664#discussion_r1369875187


More information about the net-dev mailing list