RFR: 8309118: HttpClient: Add more tests for 100 ExpectContinue with HTTP/2 [v6]
Conor Cleary
ccleary at openjdk.org
Tue Oct 24 13:46:46 UTC 2023
On Mon, 23 Oct 2023 14:17:46 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Conor Cleary has updated the pull request incrementally with one additional commit since the last revision:
>>
>> schedule completes normally on NO_ERROR, incoming_reset safely accesses volataile
>
> Hi @c-cleary this mostly look good to me now. I do have one additional suggestion though. There is a corner case where we may have received END_STREAM but are still expecting some frames: that's the case of CONTINUATION frames: in that case the END_STREAM is carried by the HEADERS frame, and the END_HEADERS will be carried by a continuation frame that follows. If we receive a RESET at that point, we should also handle it immediately and relay an exception to the caller. I believe that could be easily handled by handling reset immediately also in the case where `finalResponseCodeReceived` is `false`. See suggestion below.
Updated with your feedback @dfuch
Seems stable and makes sense 👍
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15664#issuecomment-1777236288
More information about the net-dev
mailing list