RFR: 8318788: java/net/Socks/SocksSocketProxySelectorTest.java fails on machines with no IPv6 link-local addresses
Jaikiran Pai
jpai at openjdk.org
Wed Oct 25 08:58:37 UTC 2023
On Wed, 25 Oct 2023 08:31:47 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> The test was failing on machines with no link-local addresses configured; JUnit's ParameterizedTest fails if the parameter source returns no parameters, and `linkLocalIpv6Literals` was used as a parameter source.
>
> I changed the test to non-parameterized; the test now uses the first address from `linkLocalIpv6Literals`, and is aborted if the method returns no addresses.
Hello Daniel, the change looks OK to me. Is it intentional that you want to test only one of the IP addresses (if available) from the stream instead of using a loop to test all of them (when available)?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16356#issuecomment-1778815352
More information about the net-dev
mailing list