RFR: 8318788: java/net/Socks/SocksSocketProxySelectorTest.java fails on machines with no IPv6 link-local addresses

Daniel Fuchs dfuchs at openjdk.org
Wed Oct 25 09:37:39 UTC 2023


On Wed, 25 Oct 2023 08:31:47 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> The test was failing on machines with no link-local addresses configured; JUnit's ParameterizedTest fails if the parameter source returns no parameters, and `linkLocalIpv6Literals` was used as a parameter source.
> 
> I changed the test to non-parameterized; the test now uses the first address from `linkLocalIpv6Literals`, and is aborted if the method returns no addresses.

LGTM

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16356#pullrequestreview-1696828201


More information about the net-dev mailing list